fix: show correct error message for e-service ID validation #1722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Singpass e-service ID validation relies on parsing the HTML of the login page. The login page recently added a semicolon in the line showing the error code, resulting in the FormSG server returning
null
for the error code. This causes the frontend to show an error message saying "Could not connect SingPass to validate the e-service ID", instead of showing that the e-service ID is invalid.Solution
Add the semicolon to the parsing code, and also make the comparison case-insensitive.
Screenshots
Before
After
Tests