chore: merge v5.7.1 into develop

CHANGELOG.md

@@ -4,8 +4,14 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
+#### [v5.7.1](https://github.com/opengovsg/FormSG/compare/v5.7.0...v5.7.1)
+
+- fix: correctly check Singpass title for error [`25a5ab5`](https://github.com/opengovsg/FormSG/commit/25a5ab527231b4bee04edf64a0f2f3782f1f5f3c)
+
 #### [v5.7.0](https://github.com/opengovsg/FormSG/compare/v5.6.1...v5.7.0)
 
+> 20 April 2021
+
 - fix: loosen validation for sg home numbers [`#1663`](https://github.com/opengovsg/FormSG/pull/1663)
 - chore(deps-dev): bump core-js from 3.10.1 to 3.10.2 [`#1678`](https://github.com/opengovsg/FormSG/pull/1678)
 - fix(deps): bump fp-ts from 2.10.2 to 2.10.3 [`#1677`](https://github.com/opengovsg/FormSG/pull/1677)
@@ -37,21 +43,22 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - chore: merge release v5.6.0 back to develop [`#1632`](https://github.com/opengovsg/FormSG/pull/1632)
 -  refactor(feedback-api): duplicate adminform feedback endpoints for /api/v3 [`#1589`](https://github.com/opengovsg/FormSG/pull/1589)
 - refactor(frontend-api): duplicate frontend client endpoints to new /api/v3 router [`#1574`](https://github.com/opengovsg/FormSG/pull/1574)
+- chore: bump version to 5.7.0 [`6f91f00`](https://github.com/opengovsg/FormSG/commit/6f91f0027dbe90289e083d533e90634018798b83)
 - fix: merge conflict from merging with develop [`9f0930e`](https://github.com/opengovsg/FormSG/commit/9f0930e6665a5e635fe6187e031c3c5ea50dfc41)
 
 #### [v5.6.1](https://github.com/opengovsg/FormSG/compare/v5.6.0...v5.6.1)
 
 > 13 April 2021
 
-- fix: call correct user update emergency contact endpoint [`#1631`](https://github.com/opengovsg/FormSG/pull/1631)
-- chore: bump version to v5.6.0 [`c4724a9`](https://github.com/opengovsg/FormSG/commit/c4724a9f64c6dd5cb134dd46ceae8ab6a736dbec)
 - test(AdminFormRoutes): test for equal start and end dates validation [`2d81ff4`](https://github.com/opengovsg/FormSG/commit/2d81ff4a4573a70a698596f5ac2ec1a4c5139b27)
 - chore: bump version to v5.6.1 [`c640dd1`](https://github.com/opengovsg/FormSG/commit/c640dd1e8c219f5293f36fff18f57881ae1ded73)
+- fix: use Joi.date.min() instead of Joi.date.greater() for date range [`864561c`](https://github.com/opengovsg/FormSG/commit/864561c129bebd24cfd7dca2851106066141a780)
 
 #### [v5.6.0](https://github.com/opengovsg/FormSG/compare/v5.5.1...v5.6.0)
 
 > 13 April 2021
 
+- fix: call correct user update emergency contact endpoint [`#1631`](https://github.com/opengovsg/FormSG/pull/1631)
 - fix(deps): bump winston-cloudwatch from 2.5.1 to 2.5.2 [`#1626`](https://github.com/opengovsg/FormSG/pull/1626)
 - chore(deps-dev): bump @typescript-eslint/parser from 4.21.0 to 4.22.0 [`#1627`](https://github.com/opengovsg/FormSG/pull/1627)
 - chore(deps-dev): bump date-fns from 2.20.1 to 2.20.2 [`#1628`](https://github.com/opengovsg/FormSG/pull/1628)
@@ -116,7 +123,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - chore(deps-dev): bump @typescript-eslint/eslint-plugin [`#1556`](https://github.com/opengovsg/FormSG/pull/1556)
 - fix(deps): bump @opengovsg/spcp-auth-client from 1.4.4 to 1.4.5 [`#1555`](https://github.com/opengovsg/FormSG/pull/1555)
 - refactor(corppass-ui): make ui changes for corppass [`#1533`](https://github.com/opengovsg/FormSG/pull/1533)
-- chore: bump version to v5.6.0 [`bf1874d`](https://github.com/opengovsg/FormSG/commit/bf1874d1aedec79f416cf0db3eec02eb1bcf017b)
+- chore: bump version to v5.6.0 [`c4724a9`](https://github.com/opengovsg/FormSG/commit/c4724a9f64c6dd5cb134dd46ceae8ab6a736dbec)
 
 #### [v5.5.1](https://github.com/opengovsg/FormSG/compare/v5.5.0...v5.5.1)
 
@@ -432,15 +439,14 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
 > 23 February 2021
 
-- fix: add _id key in permissionList object for updateForm validator [`#1224`](https://github.com/opengovsg/FormSG/pull/1224)
 - feat: remove updateFormValidator [`92f3f75`](https://github.com/opengovsg/FormSG/commit/92f3f75bc760f32bdb495e27eb880d53f1562093)
-- chore: bump version to v4.59.0 [`21bee76`](https://github.com/opengovsg/FormSG/commit/21bee768bb40e9eae57fe25b8a3c7b2ea3ccc130)
 - chore: bump version to v4.59.1 [`a712594`](https://github.com/opengovsg/FormSG/commit/a712594146e294a01cea13e429e4ed03109a1f70)
 
 #### [v4.59.0](https://github.com/opengovsg/FormSG/compare/v4.58.2...v4.59.0)
 
 > 23 February 2021
 
+- fix: add _id key in permissionList object for updateForm validator [`#1224`](https://github.com/opengovsg/FormSG/pull/1224)
 - chore: use formsg-sdk beta release [`#1219`](https://github.com/opengovsg/FormSG/pull/1219)
 - chore(deps-dev): bump csv-parse from 4.15.1 to 4.15.3 [`#1213`](https://github.com/opengovsg/FormSG/pull/1213)
 - refactor: move addLogin method to Billing module [`#1195`](https://github.com/opengovsg/FormSG/pull/1195)
@@ -497,7 +503,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - fix(deps): bump nodemailer from 6.4.17 to 6.4.18 [`#1143`](https://github.com/opengovsg/FormSG/pull/1143)
 - fix(deps): bump @sentry/integrations from 5.30.0 to 6.1.0 [`#1142`](https://github.com/opengovsg/FormSG/pull/1142)
 - fix(deps): bump libphonenumber-js from 1.9.8 to 1.9.11 [`#1138`](https://github.com/opengovsg/FormSG/pull/1138)
-- chore: bump version to v4.59.0 [`53bd033`](https://github.com/opengovsg/FormSG/commit/53bd03318be09e83dc549d93515830e3b7efc365)
+- chore: bump version to v4.59.0 [`21bee76`](https://github.com/opengovsg/FormSG/commit/21bee768bb40e9eae57fe25b8a3c7b2ea3ccc130)
 
 #### [v4.58.2](https://github.com/opengovsg/FormSG/compare/v4.58.1...v4.58.2)
 
@@ -807,16 +813,16 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - build: Release 4.30.1 - Fix field creation on old clients [`#74`](https://github.com/opengovsg/FormSG/pull/74)
 - Release 4.30.0 - acknowledgement for secret key backup, TypeScript migrations [`#67`](https://github.com/opengovsg/FormSG/pull/67)
 - build: empty commit to trigger PR build [`d0c6583`](https://github.com/opengovsg/FormSG/commit/d0c65838efa6731a0f10e89ff954c132b9f8b854)
-- feat: update table field styling to not rely on multiple divs [`db03da3`](https://github.com/opengovsg/FormSG/commit/db03da33eca2fc0a6174ca58d7dd8b3cfadadcea)
 - fix: return 401 for missing JWT [`e6c1947`](https://github.com/opengovsg/FormSG/commit/e6c19477b05fc4aed90b2db42916220aea2a263c)
+- test: add tests for extractJwt [`16191a9`](https://github.com/opengovsg/FormSG/commit/16191a957be0dc7f63dc4221569fac2794b7d063)
 
 #### [v4.50.2](https://github.com/opengovsg/FormSG/compare/v4.50.1...v4.50.2)
 
 > 16 December 2020
 
-- feat: update table field styling to not rely on multiple divs [`e857aed`](https://github.com/opengovsg/FormSG/commit/e857aed667145441758f09f311c2b9f16f57645b)
+- feat: update table field styling to not rely on multiple divs [`db03da3`](https://github.com/opengovsg/FormSG/commit/db03da33eca2fc0a6174ca58d7dd8b3cfadadcea)
 - fix: email format validation should allow 126/163.com, align frontend and backend validation [`be35522`](https://github.com/opengovsg/FormSG/commit/be35522e15d20521f58fada7ed3164e6c0c0894d)
-- chore: bump version to v4.50.2 [`fad62ec`](https://github.com/opengovsg/FormSG/commit/fad62ec5730412201e208332a91286fd53e2b36a)
+- chore: bump version to v4.50.2 [`1ac7be6`](https://github.com/opengovsg/FormSG/commit/1ac7be6cb69553d186ec194682ae25bd98318a8b)
 
 #### [v4.50.1](https://github.com/opengovsg/FormSG/compare/v4.50.0...v4.50.1)
 

package.json

@@ -1,7 +1,7 @@
 {
   "name": "FormSG",
   "description": "Form Manager for Government",
-  "version": "5.7.0",
+  "version": "5.7.1",
   "homepage": "https://form.gov.sg",
   "authors": [
     "FormSG <[email protected]>"

src/app/modules/spcp/spcp.service.ts

@@ -173,7 +173,7 @@ export class SpcpService {
       })
       return err(new LoginPageValidationError())
     }
-    if (title.indexOf('Error') === -1) {
+    if (title.toLowerCase().indexOf('error') === -1) {
       return ok({ isValid: true })
     } else {
       // The error page should have text like 'System Code:&nbsp<b>138</b>'