Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(admin-forms-routes): remove duplicate logic route endpoint #1703

Merged
merged 1 commit into from
Apr 22, 2021
Merged

chore(admin-forms-routes): remove duplicate logic route endpoint #1703

merged 1 commit into from
Apr 22, 2021

Conversation

orbitalsqwib
Copy link
Contributor

Problem

Currently, there is a redundant DELETE /admin/forms/:formId/logic/:logicId endpoint defined in the admin-forms-routes file. This endpoint already exists in admin-forms.logic.routes.

Solution

Improvements:

  • Remove redundant endpoint

tshuli
tshuli approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbitalsqwib orbitalsqwib merged commit f597b6b into develop Apr 22, 2021
@orbitalsqwib orbitalsqwib deleted the fix/remove-duplicate-route branch April 22, 2021 08:45
@mantariksh mantariksh mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli approved these changes

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orbitalsqwib @mantariksh @tshuli