feat(webhooks): streamline webhook response data #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The webhook response data stored in the database has a couple of superfluous fields:
errorMessage
is useless because it is always a standardaxios
error message, e.g. "Request failed with status code 400".statusText
is useless because it is just the standard HTTP status text, e.g.'OK'
for 200Furthermore, fields that should always be present (webhook URL, signature, status code) are not marked as required in the database schema.
Solution
Remove the superfluous fields and mark the rest as
required
where appropriate.headers
anddata
were not made required as they may be empty strings.