Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): log client form reCAPTCHA failure to GA #1684

Merged
merged 2 commits into from
Apr 26, 2021
Merged

feat(client): log client form reCAPTCHA failure to GA #1684

merged 2 commits into from
Apr 26, 2021

Conversation

jia1
Copy link
Member

@jia1 jia1 commented Apr 20, 2021 •
edited by karrui
Loading

Problem

This PR adds a Google Analytics logging invocation on any recaptcha instantiation failure

Closes #1306

Solution

  • feat: log client form reCAPTCHA failure to GA

Screenshots

GA Logging screenshot
Screenshot 2021-04-26 at 3 28 27 PM
Screenshot 2021-04-26 at 3 28 19 PM

@karrui karrui self-assigned this Apr 20, 2021
@karrui
Copy link
Contributor

karrui commented Apr 21, 2021 •
edited
Loading

I will pull and test to see if GA event is fired (somehow....)

EDIT: Tested by building local build and using private IP address to test; see screenshots

@karrui karrui marked this pull request as ready for review April 26, 2021 07:29
@karrui karrui requested a review from mantariksh April 26, 2021 07:30
@karrui karrui changed the title feat: log client form reCAPTCHA failure to GA feat(client): log client form reCAPTCHA failure to GA Apr 26, 2021
@karrui karrui merged commit 3652e1b into develop Apr 26, 2021
@karrui karrui deleted the feat/log-recaptcha-failure-to-ga branch April 26, 2021 08:03
@mantariksh mantariksh mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees

@karrui karrui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log reCaptcha connection failure notification
3 participants
@jia1 @karrui @mantariksh