Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: uninstall sinon and ts-mock-imports (forreal) #1611

Merged
merged 2 commits into from
Apr 12, 2021
Merged

chore: uninstall sinon and ts-mock-imports (forreal) #1611

merged 2 commits into from
Apr 12, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Apr 9, 2021

Problem

ts-mock-import was only being used in a couple places and they can all be replaced with jest spies. With that, we can also remove sinon since jasmine and ts-mock-import has been removed.

Solution

I guess @mantariksh needs to cancel his cancellation of sinon

@karrui karrui requested a review from mantariksh April 9, 2021 05:49
@mantariksh mantariksh merged commit 04c2eed into develop Apr 12, 2021
@karrui karrui mentioned this pull request Apr 13, 2021
Merged
@karrui karrui deleted the chore/remove-sinon-and-ts-mock-imports branch April 13, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @mantariksh