Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rearrange directory structure #1606

Merged
merged 8 commits into from
Apr 12, 2021
Merged

chore: rearrange directory structure #1606

merged 8 commits into from
Apr 12, 2021

Conversation

mantariksh
Copy link
Contributor

Problem

Repo structure is inconsistent in a couple of ways:

  • Some backend tests are within __tests__ folders, while some are in tests/unit/backend
  • src/loaders and src/config are outside src/app, even though they are used purely on the server

Solution

  • Move all tests into __tests__ folder so they are as close as possible to the modules being tested.
  • Move src/loaders and src/config into src/app and fix all relevant imports and mocks.
  • Update the backend structure documented in ARCHITECTURE.md.

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup.
couldn't comment on the PR since they were just renamed, but should logic.spec.ts and file-validation.spec.ts be in the shared folder tests instead, since the files they are testing are not in /app/utils?

lgtm otherwise.

@mantariksh
Copy link
Contributor Author

@karrui good catch!

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantariksh mantariksh merged commit 0797899 into develop Apr 12, 2021
@karrui karrui mentioned this pull request Apr 13, 2021
@mantariksh mantariksh deleted the chore/rearrange branch April 13, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants