-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rearrange directory structure #1606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup.
couldn't comment on the PR since they were just renamed, but should logic.spec.ts
and file-validation.spec.ts
be in the shared folder tests instead, since the files they are testing are not in /app/utils
?
lgtm otherwise.
@karrui good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem
Repo structure is inconsistent in a couple of ways:
__tests__
folders, while some are intests/unit/backend
src/loaders
andsrc/config
are outsidesrc/app
, even though they are used purely on the serverSolution
__tests__
folder so they are as close as possible to the modules being tested.src/loaders
andsrc/config
intosrc/app
and fix all relevant imports and mocks.ARCHITECTURE.md
.