refactor: remove typecasts and non-null assertions #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
approved these changes
Apr 8, 2021
src/app/modules/submission/email-submission/email-submission.controller.ts
Outdated
Show resolved
Hide resolved
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
src/app/modules/submission/encrypt-submission/encrypt-submission.controller.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Type casting and non-null assertions limit the type safety provided by the compiler.
Closes #42
Closes #317
Solution
Remove all non-null assertions as well as type casts which were highlighted under #42. In addition, introduce a linting rule which forbids non-null assertions.
Typing of SPCP JWT payload
This change was slightly trickier than the rest. The problem was that both Singpass and Corppass JWTs were typed with the same
JwtPayloadtype, resulting in difficulty telling when theuserInfoproperty was present, since it is only present for Corppass JWTs.The solution was to separate the logic for extracting Singpass vs Corppass JWTs. This was easy to accomplish, which suggests that this should have been the implementation from the start.