refactor(feedback-api): duplicate adminform feedback endpoints for /api/v3 #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… /api/v3 router - duplicate adminform feedback endpoint functionalities and update them to use the new api v3 routes - update v3 router to use new endpoints - update frontend api calls to use new endpoints
karrui
requested changes
Apr 8, 2021
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.feedback.routes.spec.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.feedback.routes.spec.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/admin-forms.settings.routes.ts
Outdated
Show resolved
Hide resolved
- remove duplicated auth middleware from feedback endpoints - import index level router for form-route tests to account for shifted auth middleware - shard index into admin-forms.routes and index to follow convention
karrui
reviewed
Apr 12, 2021
|
Feedback is an uncountable noun, sorry for the fail |
orbitalsqwib
force-pushed
the
ref/feedback-api
branch
from
ec69986 to
5e0836e
Compare
karrui
approved these changes
Apr 13, 2021
src/app/routes/api/v3/admin/forms/admin-forms.feedback.routes.ts
Outdated
Show resolved
Hide resolved
karrui
approved these changes
Apr 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Update current adminform feedback endpoints to their /api rooted endpoints to follow a RESTful hierarchy.
Closes #1508
Solution
Features:
Tests