-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Extract delete logic endpoint #1586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes~
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.routes.spec.ts
Outdated
Show resolved
Hide resolved
@karrui thanks for reviewing, for re-review please |
src/app/modules/form/admin-form/__tests__/admin-form.service.spec.ts
Outdated
Show resolved
Hide resolved
src/app/routes/api/v3/admin/forms/__tests__/admin-forms.settings.routes.spec.ts
Outdated
Show resolved
Hide resolved
@karrui thanks for reviewing, for re-review pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more changes;
will the changes to make client use this endpoint will be in a separate PR or was it just missed?
@karrui simplified the return; frontend changes will come in separate PR |
src/app/modules/form/admin-form/__tests__/admin-form.controller.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/form/admin-form/__tests__/admin-form.controller.spec.ts
Outdated
Show resolved
Hide resolved
@karrui actually I added on the frontend changes, for review pls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes on the frontend handling requested, lgtm otherwise
src/public/modules/forms/admin/components/edit-logic.client.component.js
Outdated
Show resolved
Hide resolved
ac7b7e7
to
8119709
Compare
src/app/modules/form/admin-form/__tests__/admin-form.service.spec.ts
Outdated
Show resolved
Hide resolved
@mantariksh thanks for reviewing, for re-review pls |
@mantariksh thanks for reviewing, for re-review pls |
Co-authored-by: Antariksh Mahajan <[email protected]>
Problem
Closes #1490
Tests
DELETE /forms/:formId/logic/:logicId
returns 200 when formId and logicId are correct and that the specific logicId is deleted from db