Test: publicform integration tests #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
changed the base branch from
develop
to
refactor/public-forms-endpoint
seaerchin
changed the title
seaerchin
requested review from
karrui and
mantariksh
and removed request for
karrui
karrui
approved these changes
Apr 7, 2021
src/app/modules/form/public-form/__tests__/public-form.routes.spec.ts
Outdated
Show resolved
Hide resolved
| const expectedResponseBody = JSON.parse( | ||
| JSON.stringify({ | ||
| message: | ||
| 'If you think this is a mistake, please contact the agency that gave you the form link.', |
There was a problem hiding this comment.
The body response should have 2 more key-values:
formTitle: string
isPageFound: booleancheck if this is a regression
There was a problem hiding this comment.
good catch. this is a regression. will update tests and the controller
seaerchin
force-pushed
the
test/publicform-integration-tests
branch
from
a9445ab to
74507d6
Compare
seaerchin
force-pushed
the
test/publicform-integration-tests
branch
from
74507d6 to
c90cf27
Compare
seaerchin
force-pushed
the
test/publicform-integration-tests
branch
from
c90cf27 to
e4790c5
Compare
mantariksh
approved these changes
Apr 12, 2021
| message: string | ||
| } | ||
|
|
||
| export interface PrivateFormErrorDto extends ErrorDto { |
There was a problem hiding this comment.
it doesn't make a difference but for the record, it wasn't necessary to change this to an interface, since you can use & to achieve the same thing
| // Specialized error response for PrivateFormError. | ||
| // This is to maintain backwards compatibility with the middleware implementation | ||
| if (error instanceof PrivateFormError) { | ||
| return res.status(statusCode).json({ |
There was a problem hiding this comment.
noticed you fixed a regression here. in future it would be good to separate this kind of change into a different PR which can be reviewed with greater urgency. if you name your PR as you did here, other devs may (rightly) assume (as I did) that this PR only contains tests.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
current public form end point does not have any integration tests and only has unit tests on the controller. this PR adds integration tests for HTTP errors.
Part of #1513
Solution
Added integration tests for
GET /:formId/publicformendpoint.