-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: collapse encrypt preview submission middleware #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
ref/encrypt-preview-middleware
branch
from
April 7, 2021 11:54
a7ea38c
to
6615182
Compare
mantariksh
force-pushed
the
ref/encrypt-preview-middleware
branch
from
April 8, 2021 02:24
c2f7361
to
d49ae3f
Compare
mantariksh
requested review from
karrui,
tshuli,
seaerchin and
orbitalsqwib
and removed request for
karrui
April 8, 2021 02:45
karrui
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
src/app/modules/submission/encrypt-submission/__tests__/encrypt-submission.service.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/submission/encrypt-submission/encrypt-submission.service.ts
Show resolved
Hide resolved
seaerchin
reviewed
Apr 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the middleware for the endpoint which handles storage mode preview submissions.
Closes #1435
Other improvements
While writing integration tests, I noticed a couple of issues with the Joi validation shared by the actual submission and preview submission endpoints:
helper.error
results in Joi returning an error message, because they require a custom string (e.g.'any.custom'
) to be passed as the first argument, rather than our own error message.encryptedFile
key in individual attachments was not a required key, even though it should be.These two issues have been fixed in
encrypt-submission.middleware.ts
.Tests