Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(auth-api): duplicate auth endpoints to new /api/v3 router #1551

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

orbitalsqwib
Copy link
Contributor

@orbitalsqwib orbitalsqwib commented Apr 5, 2021

Problem

Updates current user auth endpoints to their /api rooted endpoints to follow a RESTful hierarchy.

Closes #1499

Solution

Features:

  • duplicate auth endpoint functionality and update endpoints
  • duplicated integration tests for new endpoint
  • update v3 router to use new endpoints
  • update frontend api calls to use new endpoints

- duplicate auth endpoint functionality and update endpoints
- update v3 router to use new endpoints
- update frontend api calls to use new endpoints
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you also duplicate the integration tests to the new endpoint?

@orbitalsqwib orbitalsqwib requested a review from karrui April 5, 2021 07:58
@orbitalsqwib orbitalsqwib marked this pull request as ready for review April 6, 2021 02:42
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orbitalsqwib orbitalsqwib merged commit ae0fb75 into develop Apr 6, 2021
@orbitalsqwib orbitalsqwib deleted the ref/auth-api branch April 6, 2021 03:04
tshuli pushed a commit that referenced this pull request Apr 6, 2021
* refactor(auth-api): duplicate auth endpoints to new /api/v3 router

- duplicate auth endpoint functionality and update endpoints
- update v3 router to use new endpoints
- update frontend api calls to use new endpoints

* test(auth-api): duplicate integration tests for new endpoint
@tshuli tshuli mentioned this pull request Apr 6, 2021
@karrui karrui mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Duplicate auth endpoints to their new /api counterparts
2 participants