-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Security upgrade mongoose from 5.11.10 to 5.12.3 #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MQUERY-1089718
mantariksh
reviewed
Apr 6, 2021
LoneRifle
force-pushed
the
snyk-fix-7575fc7d4cf936e7b599718c2a623e28
branch
from
April 6, 2021 02:49
918a39f
to
8d84d09
Compare
mantariksh
reviewed
Apr 6, 2021
- recast FormSchema as FormDocumentSchema so that we can register methods specific to the handling of IFormDocument - declare Schema.Types.DocumentArrayWithLooseDiscriminator so that we can more easily register our sub-schema TODO - submit a patch to mongoose to loosen the type def for `DocumentArray.discriminator()`
LoneRifle
force-pushed
the
snyk-fix-7575fc7d4cf936e7b599718c2a623e28
branch
from
April 6, 2021 02:59
8d84d09
to
aa7729e
Compare
mantariksh
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for picking this up and adding the explanations!
tshuli
pushed a commit
that referenced
this pull request
Apr 6, 2021
* fix: package.json & package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-MQUERY-1089718 * refactor(mongoose): rework type defs * refactor(models): rework form.server.model for mongoose - recast FormSchema as FormDocumentSchema so that we can register methods specific to the handling of IFormDocument - declare Schema.Types.DocumentArrayWithLooseDiscriminator so that we can more easily register our sub-schema TODO - submit a patch to mongoose to loosen the type def for `DocumentArray.discriminator()` Co-authored-by: LoneRifle <[email protected]>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Fixes #1532
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 7.5
SNYK-JS-MQUERY-1089718
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: mongoose
The new version differs by 250 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic