Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: collapse middlewares of /adminform/submissions/download #1442

Merged
merged 3 commits into from
Mar 24, 2021
Merged

ref: collapse middlewares of /adminform/submissions/download #1442

merged 3 commits into from
Mar 24, 2021

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Mar 24, 2021

Problem

This PR cleans up the janky authEncryptedResponseAccess middleware used in the /adminform/submissions/download endpoint and collapses the used middlewares in the handleStreamEncryptedResponses controller handler.

This PR is just one of the few PRs needed to remove total usage of the authEncryptedResponseAccess middleware.

Related to #1434

Solution

Improvements:

  • feat: collapse middlewares for submission download endpoint

Tests

  • unit tests have been added (where possible) for the refactored controller handler function

Manual tests

  • Downloading of storage mode responses should work as is
  • Downloading of storage mode responses with attachments should work as is

@karrui karrui merged commit 8ec05eb into develop Mar 24, 2021
@karrui karrui deleted the ref/collapse-encrypt-download-api branch March 24, 2021 09:29
@mantariksh mantariksh mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seaerchin seaerchin seaerchin left review comments

@mantariksh mantariksh mantariksh approved these changes

@tshuli tshuli Awaiting requested review from tshuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrui @mantariksh @seaerchin