refactor: update getPublicForm endpoint to typescript#1398

Merged

seaerchin merged 89 commits intodevelopfrom refactor/public-forms-endpoint

Apr 8, 2021

+1,674-325

Commits on Mar 30, 2021

refactor(modules/spcp): shifts get spcp session out into service
seaerchin
committed
refactor(modules/form): adds utility methods and refactored checkFormSubmission
seaerchin
committed
refactor(modules/form): refactors GET public forms end point from js to ts
seaerchin
committed
refactor(utils): adds utility type for all possible db errors
seaerchin
committed
fix(types/form): fixed the type of submissionLimit to allow for null
seaerchin
committed
refactor(modules/form): updated deactiveForm so that it uses never throw and adds logging
seaerchin
committed
refactor(modules/form): updated form limit checking to account for submission limit being null
seaerchin
committed
refactor(modules/form): adds logging to getSpcpSession
seaerchin
committed
refactor(modules/form): refactored handleGetPublicForm for clarity and code cleanliness
seaerchin
committed
refactor(publicformctrl): refactored handler for GET public forms to be cleaner and easier to read
seaerchin
committed
refactor(spcpsvc): added logging to extract JWT; updated typings for getSpcpSession
seaerchin
committed
revert(formsvc): removes retrievePublicForm (will be done in another PR) to limit scope
seaerchin
committed
style(public-form/controller): updated object to use variables
seaerchin
committed
style(services/types): updated documentation for functions and removed unneeded logging
seaerchin
committed
refactor(public-form/controller): refactored spcp flow so it's clearer
seaerchin
committed
refactor(public-form/controller): wip for myInfo
seaerchin
committed
refactor(myinfo): extracts myInfoCookiePayload to 2 types and adds utility function to differentiate
seaerchin
committed
refactor(public-form/controller): refactored myinfo chunk so it's neater
seaerchin
committed
test(form/service): fixes failing tests due to checkFormSubmissionLimitAndDeactivateForm
seaerchin
committed
refactor(myinfo): removed unneeded cookie type and updated extractSuccessfulCookie to reflect this
seaerchin
committed
docs(public-form/controller): adds docs to confusing sections of handlGetPublicForm
seaerchin
committed
test(public-form/controller/test): add test for database error when GET /getPublicForm
seaerchin
committed
test(public-form/controller/tests): add more tests
seaerchin
committed
test(public-form/controller/test): adds test for success cases
seaerchin
committed
refactor(myinfo): extracts out chunks form public-form controller into myinfo service
seaerchin
committed
refactor(public-form/controller): updated controller to use MyInfoFactory method
seaerchin
committed
test(public-form/controller/test): updated tests to use mocks
seaerchin
committed
fix(public-form/controller): fixed succesful 200 when auth using myInfo returning a private view
seaerchin
committed
test(public-form/controller/test): adds remaining tests for myInfo
seaerchin
committed
refactor(spcp): combined controller calls to spcp services into a single spcp call
seaerchin
committed
refactor(myinfo): refactored multiple controller calls to myInfo into a single call
seaerchin
committed
refactor(public-form): updated typings and refactored getPublicForm to be cleaner
seaerchin
committed
style(public-form/controller/test): updated comments in tests to use when
seaerchin
committed
refactor(form/service): updated deactiveForm to return the form itself; updated tests
seaerchin
committed
style(myinfo): extractMyInfoData renamed to fetchMyInfoData
seaerchin
committed
fix(public-form/controller): fixed bug where wrong extract cookie method is being called
seaerchin
committed
refactor(spcp/myinfo): removed extra logging in spcp; updated names in myinfo
seaerchin
committed
test(spcp/service/test): adds service tests
seaerchin
committed
test(spcp/service/test): adds unit tests for createFormWithSpcpSession
seaerchin
committed
test(myinfo.service): adds tests for createFormWithMyInfo
seaerchin
committed
feat(form): adds new errors and utility methods
seaerchin
committed
refactor(public-form): refactor to account for intarnet
seaerchin
committed
refactor(public-form/controller): added compatability for checking intranet access
seaerchin
committed
test(public-form/controller): adds tests for checking intranet; fixes old tests due to this addition
seaerchin
committed

Commits on Apr 6, 2021

Commits on Apr 7, 2021

Commits on Apr 8, 2021