refactor: rename type to AnalyticStatsDto #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
reviewed
Mar 16, 2021
mantariksh
reviewed
Mar 16, 2021
karrui
approved these changes
Mar 16, 2021
| @@ -1,4 +1,4 @@ | |||
| export type AnalyticStats = { | |||
| export type AnalyticStatsDto = { | |||
There was a problem hiding this comment.
should DTOs live in a shared folder like shared/typings? No big deal for now, probably can do a cleanup in the future
There was a problem hiding this comment.
yeah, i think they can live in e.g. shared/types/analytics/dto. this will be a big reorganisation, so I'm not keen to do it now and break everyone's imports.
karrui
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just occurred to me that
AnalyticStatswas in fact a data transfer object that presents a specific data format to the client, so I renamed it. I'm leaving the file in/types/analyticsinstead of/sharedso that the cleanup can happen all in one go in a future PR.