refactor: stop replacing spaces in SAML artifact #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
approved these changes
Mar 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the past, SPCP SAML artifacts were not URL-encoded when we received them at our login endpoints. This means that Express would automatically parse
+characters as spaces, and we had to manually change them back to+.SAML artifacts are now URL-encoded so this is no longer necessary.
Closes #1322
Solution
Remove the code which replaced spaces with + in the SAML artifact.
Once this change was made, the
parseOOBParamsfunction was taking in the SAML artifact as a parameter and returning it unchanged. This made little sense, so the function signature was changed to stop returning the SAML artifact.