feat: add timestamp to form submission end page #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
reviewed
Feb 18, 2021
@mantariksh ya this is the latest already, since we are pushing back the "Save response" feature |
|
figma with updated design https://www.figma.com/file/ta5tjjBqphML8LPRkmxD53/DesignMaster_v2 @jia1 @karrui |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shows form submission timestamp above "Thank you for..." upon successful form submission.
Closes #1103
Things to take note of
The timestamp shown may not be equal to the actual form submission timestamp in the database (difference of at most 1 min unless very poor network conditions after submission), because this rendered timestamp is generated on the fly upon render. Let me know if this is not okay.
Before & After Screenshots
BEFORE:
AFTER:
