Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask cp uid in autoreply to respondent #1109

Merged
merged 8 commits into from
Feb 9, 2021

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Feb 9, 2021

Problem

Closes #101

Solution

Before & After Screenshots

BEFORE:

Screenshot 2021-02-02 at 8 59 12 PM
Screenshot 2021-02-02 at 8 59 04 PM

AFTER:

Screenshot 2021-02-02 at 8 58 30 PM
Screenshot 2021-02-02 at 8 58 19 PM

Tests

  • Create a corppass form with email autoreply and pdf response. Submit form. Check that the autoreply email and pdf response both have a masked UID number with only the last 4 characters shown (e.g. *****123A)
  • Add a text field to the form with the title 'CorpPass Validated UID'. Check that the response on the text field is not masked in autoreply.
  • Check that the email response to the admin still has the full UID number.

@liangyuanruo
Copy link
Contributor

lgtm, to merge after testing

@tshuli tshuli marked this pull request as ready for review February 9, 2021 08:20
@tshuli tshuli changed the title Feat/remove cp nric function feat: mask cp uid in autoreply to respondent Feb 9, 2021
@tshuli tshuli merged commit ec5aa9a into develop Feb 9, 2021
@karrui karrui deleted the feat/remove-cp-nric-function branch April 21, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants