Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate MyInfo fields for V3 (step 1 - frontend) #1071

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

mantariksh
Copy link
Contributor

Problem

The following MyInfo fields are set to return empty strings, and therefore should be deprecated:

  • Home number
  • Billing address
  • Mailing address
  • Highest education level
  • School name
  • Graduation year

Solution

The deprecation requires 3 steps:

  1. Stop allowing admins to add these fields
  2. Database migration to convert these fields to regular (non-MyInfo) fields
  3. Drop support for these fields

This PR addresses step 1. We need to hide these fields from the admin panel while still supporting existing fields, so we simply filter out the fields in the form builder.

Tests

  • Home number, mailing address, billing address, education level, school name and graduation year are missing from MyInfo options in Build tab
  • Existing forms with these fields can still be submitted
  • Existing forms with these fields can still be edited. The deprecated fields can be edited, reordered and deleted.

@liangyuanruo
Copy link
Contributor

liangyuanruo commented Feb 3, 2021

We could potentially release this low-risk PR ahead of time to pave the way for step 2

@mantariksh mantariksh merged commit 5d6ae59 into develop Feb 4, 2021
@tshuli tshuli mentioned this pull request Feb 10, 2021
@mantariksh mantariksh deleted the deprecate-myinfo/frontend branch April 13, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants