refactor: Minor refactoring of the submissions client factory #1040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Minor refactoring for the submissions client factory.
I suspect a more substantial rewrite will be needed for major refactoring, as there is a lot of global variable capture and usage which makes it hard to decompose existing functions.
Solution
generateDownloadUrl
into its own functionkillWorker
function instead of calling worker terminate by itself.