Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Minor refactoring of the submissions client factory #1040

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

frankchn
Copy link
Contributor

Problem

Minor refactoring for the submissions client factory.

I suspect a more substantial rewrite will be needed for major refactoring, as there is a lot of global variable capture and usage which makes it hard to decompose existing functions.

Solution

  • Pulled generateDownloadUrl into its own function
  • Used killWorker function instead of calling worker terminate by itself.

@frankchn frankchn requested a review from liangyuanruo January 25, 2021 00:08
@liangyuanruo liangyuanruo merged commit 5bffa35 into develop Jan 25, 2021
@liangyuanruo liangyuanruo deleted the frank-refactor branch January 25, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants