Remove isTemplate validation on duplicate template API after all clients are updated #792
Comments
karrui
added a commit
that referenced
this issue
Dec 7, 2020
karrui
added a commit
that referenced
this issue
Dec 7, 2020
* feat(AuthSvc): add getFormIfPublic service fn (and tests) * test(FormSvc): add tests for isFormPublic function * feat(AdminFormCtl): add handleCopyTemplateForm handler fn * feat(AdminFormRoutes): add Joi validation to /adminform/copy api * ref(AdminFormRoutes): use new handleCopyTemplateForm handler * feat: remove and track sending of isTemplate param when using template related to #792 * test(AdminFormCtl): add tests for handleCopyTemplateForm * feat: remove unused adminForms.duplicate function * feat(AuthSvc): make overridden error message more generic * ref(AdminFormCtl): unnest call to get dashboard view of duped form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When duplicating templates,
isTemplateis being sent to the backend as a body parameter.This is legacy code that was used to reset
form.customLogotoundefinedso that the form logos are not copied over. However,form.customLogois a deprecated key and will be removed from the codebase (#787), and theisTemplatebody parameter is actually not doing anything.This issue is opened to track the removal of validating
isTemplatewhen frontend has stopped including it in the body parameter.The text was updated successfully, but these errors were encountered: