fix(mail): failure to render mail (#7890)

* chore: add more logs * fix: react-dom should be in deps not devDeps
opengovsg · Nov 15, 2024 · 2a22489 · 2a22489
1 parent 02bcba6
commit 2a22489
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -132,6 +132,7 @@
     "promise-timeout": "^1.3.0",
     "puppeteer-core": "22.6.3",
     "react": "^18.3.0",
+    "react-dom": "^18.3.1",
     "react-email": "^3.0.2",
     "slick-carousel": "1.8.1",
     "sns-validator": "^0.3.5",
@@ -226,7 +227,6 @@
     "maildev": "^2.1.0",
     "mockdate": "^3.0.5",
     "prettier": "^3.3.3",
-    "react-dom": "^18.3.1",
     "regenerator": "^0.14.10",
     "rimraf": "^5.0.5",
     "stripe-event-types": "^3.1.0",

diff --git a/src/app/services/mail/mail.service.ts b/src/app/services/mail/mail.service.ts
@@ -464,7 +464,15 @@ export class MailService {
 
     const generatedHtml = fromPromise(
       render(BounceNotification(htmlData)),
-      () => {
+      (e) => {
+        logger.error({
+          message: 'Failed to render BounceNotification',
+          meta: {
+            action: 'sendBounceNotification',
+            error: e,
+          },
+        })
+
         return new MailGenerationError(
           'Error generating bounce notification email',
         )
@@ -1095,10 +1103,16 @@ export class MailService {
 
     const generatedHtml = fromPromise(
       render(MrfWorkflowEmail(htmlData)),
-      () => {
-        return new MailGenerationError(
-          'Error generating bounce notification email',
-        )
+      (e) => {
+        logger.error({
+          message: 'Failed to render MrfWorkflowEmail',
+          meta: {
+            action: 'sendMRFWorkflowStepEmail',
+            error: e,
+          },
+        })
+
+        return new MailGenerationError('Error generating mrf workflow email')
       },
     )
 
@@ -1138,9 +1152,17 @@ export class MailService {
 
     const generatedHtml = fromPromise(
       render(MrfWorkflowCompletionEmail(htmlData)),
-      () => {
+      (e) => {
+        logger.error({
+          message: 'Failed to render MrfWorkflowCompletionEmail',
+          meta: {
+            action: 'sendMrfWorkflowCompletionEmail',
+            error: e,
+          },
+        })
+
         return new MailGenerationError(
-          'Error generating bounce notification email',
+          'Error generating mrf workflow completion email',
         )
       },
     )
@@ -1190,9 +1212,17 @@ export class MailService {
 
     const generatedHtml = fromPromise(
       render(MrfWorkflowCompletionEmail(htmlData)),
-      () => {
+      (e) => {
+        logger.error({
+          message: 'Failed to render MrfWorkflowCompletionEmail',
+          meta: {
+            action: 'sendMrfApprovalEmail',
+            error: e,
+          },
+        })
+
         return new MailGenerationError(
-          'Error generating bounce notification email',
+          'Error generating mrf workflow completion email',
         )
       },
     )