refactor(angularjs): remove angular-moment (#2154)

As we have no need for the AngularJS filters and directives that
angular-moment provides, remove it completely, referencing moment
as a CommonJS module instead

package.json

@@ -72,7 +72,6 @@
     "angular-cookies": "~1.8.2",
     "angular-drag-scroll": "^0.2.1",
     "angular-messages": "^1.8.2",
-    "angular-moment": "~1.3.0",
     "angular-permission": "~1.1.1",
     "angular-resource": "^1.8.2",
     "angular-sanitize": "^1.8.2",

src/public/main.js

@@ -13,7 +13,6 @@ const moduleDependencies = [
   'ngResource',
   'ui.router',
   'ui.bootstrap',
-  'angularMoment',
   'vcRecaptcha',
   'users',
   'ngFileUpload',
@@ -55,7 +54,6 @@ require('angular-permission/dist/angular-permission')
 require('@opengovsg/angular-recaptcha-fallback')
 require('angular-resource')
 require('angular-sanitize')
-require('angular-moment')
 require('angular-messages')
 
 require('angular-ui-bootstrap')
@@ -85,9 +83,6 @@ const appName = 'FormSG'
 // Add module dependencies
 const app = angular.module(appName, moduleDependencies)
 
-// Override moment using Angular's dependency injection
-app.constant('moment', require('moment-timezone'))
-
 // Setting HTML5 Location Mode
 angular.module(appName).config([
   '$locationProvider',

src/public/modules/forms/admin/controllers/admin-form.client.controller.js

@@ -2,6 +2,7 @@
 
 const { StatusCodes } = require('http-status-codes')
 const get = require('lodash/get')
+const moment = require('moment-timezone')
 const { LogicType } = require('../../../../../types')
 const UpdateFormService = require('../../../../services/UpdateFormService')
 const UserService = require('../../../../services/UserService')
@@ -43,7 +44,6 @@ angular
     '$uibModal',
     'FormData',
     'FormFields',
-    'moment',
     'Toastr',
     '$state',
     '$window',
@@ -58,7 +58,6 @@ function AdminFormController(
   $uibModal,
   FormData,
   FormFields,
-  moment,
   Toastr,
   $state,
   $window,

src/public/modules/forms/admin/controllers/list-forms.client.controller.js

@@ -1,6 +1,8 @@
 'use strict'
 
 const get = require('lodash/get')
+const moment = require('moment-timezone')
+
 const BetaService = require('../../../../services/BetaService')
 
 const UserService = require('../../../../services/UserService')
@@ -12,7 +14,6 @@ angular
     '$scope',
     'FormApi',
     '$uibModal',
-    'moment',
     '$state',
     '$timeout',
     '$window',
@@ -25,7 +26,6 @@ function ListFormsController(
   $scope,
   FormApi,
   $uibModal,
-  moment,
   $state,
   $timeout,
   $window,

src/public/modules/forms/admin/controllers/view-responses.client.controller.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const moment = require('moment-timezone')
+
 const {
   processDecryptedContent,
 } = require('../../helpers/process-decrypted-content')
@@ -24,7 +26,6 @@ angular
     '$timeout',
     '$location',
     '$anchorScroll',
-    'moment',
     ViewResponsesController,
   ])
 
@@ -39,7 +40,6 @@ function ViewResponsesController(
   $timeout,
   $location,
   $anchorScroll,
-  moment,
 ) {
   const vm = this
 

src/public/modules/forms/base/components/end-page.client.component.js

@@ -1,5 +1,7 @@
 'use strict'
 
+const moment = require('moment-timezone')
+
 angular.module('forms').component('endPageComponent', {
   templateUrl: 'modules/forms/base/componentViews/end-page.html',
   bindings: {
@@ -13,11 +15,11 @@ angular.module('forms').component('endPageComponent', {
     colorTheme: '@',
     submissionId: '@',
   },
-  controller: ['SpcpSession', '$window', 'moment', endPageController],
+  controller: ['SpcpSession', '$window', endPageController],
   controllerAs: 'vm',
 })
 
-function endPageController(SpcpSession, $window, moment) {
+function endPageController(SpcpSession, $window) {
   const vm = this
 
   vm.timestamp = moment().format('D MMM YYYY, HH:mm')