Skip to content

Commit

Permalink
chore: remove failing dd command
Browse files Browse the repository at this point in the history
  • Loading branch information
kevin9foong committed Dec 4, 2024
1 parent d313f5d commit 2343a6d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions .github/workflows/deploy-ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup secrets for datadog sourcemap deployment
run: |
echo "APP_VERSION=$(jq -r .version package.json)-$(echo ${GITHUB_REF##*/})-$(echo ${GITHUB_SHA} | cut -c1-8)" >> $GITHUB_ENV
Expand Down
14 changes: 7 additions & 7 deletions Dockerfile.production
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ ARG REPO_URL
# Upload datadog source maps from secret mount, id MUST be `id=dd_api_key` in the docker build command
# Mount creates a file inside /run/secrets/dd_api_key, and source to load the environment variables
# For the content of the mounted file is only accessible in the RUN command where it’s referred in, use && command.
RUN --mount=type=secret,id=dd_api_key \
export DATADOG_API_KEY=$(cat /run/secrets/dd_api_key) && \
npx @datadog/datadog-ci sourcemaps upload ./dist/frontend \
--service=formsg-react \
--release-version=$APP_VERSION \
--minified-path-prefix=$APP_URL \
--repository-url=$REPO_URL
# RUN --mount=type=secret,id=dd_api_key \
# export DATADOG_API_KEY=$(cat /run/secrets/dd_api_key) && \
# npx @datadog/datadog-ci sourcemaps upload ./dist/frontend \
# --service=formsg-react \
# --release-version=$APP_VERSION \
# --minified-path-prefix=$APP_URL \
# --repository-url=$REPO_URL

RUN npm prune --production --legacy-peer-deps

Expand Down

0 comments on commit 2343a6d

Please sign in to comment.