fix: allow underscores in form esrvcId validation

opengovsg · Jul 29, 2021 · 1e7f725 · 1e7f725
1 parent 027a399
commit 1e7f725
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/app/models/form.server.model.ts b/src/app/models/form.server.model.ts
@@ -404,8 +404,8 @@ const compileFormModel = (db: Mongoose): IFormModel => {
         type: String,
         required: false,
         validate: [
-          /^([a-zA-Z0-9-]){1,25}$/i,
-          'e-service ID must be alphanumeric, dashes are allowed',
+          /^([a-zA-Z0-9-_]){1,25}$/i,
+          'e-service ID must be alphanumeric, underscores and dashes are allowed',
         ],
       },
 

diff --git a/src/public/modules/forms/admin/directiveViews/settings-form.client.view.html b/src/public/modules/forms/admin/directiveViews/settings-form.client.view.html
@@ -301,7 +301,7 @@
                     name="esrvcId"
                     ng-model="tempForm.esrvcId"
                     placeholder="{{ ['SP', 'MyInfo'].includes(type.val) ? 'Enter Singpass e-service ID' : 'Enter Corppass e-service ID' }}"
-                    ng-pattern="/^([a-zA-Z0-9\-]){1,25}$/i"
+                    ng-pattern="/^([a-zA-Z0-9\-\_]){1,25}$/i"
                     ng-keyup="($event.keyCode === 13 && settingsForm.esrvcId.$valid) && saveForm()"
                     ng-blur="(settingsForm.esrvcId.$valid) && saveForm()"
                     ng-disabled="(isFormPublic() && !isPublicWithoutEsrvcId())"