Merge pull request #3525 from opengovsg/release-al2-hotfix-v5.43.2

feat(BounceController): log SNS topic confirmation notification emails
opengovsg · Feb 28, 2022 · 12b28a6 · 12b28a6
2 parents 5ef1e34 + 2a28e5d
commit 12b28a6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/app/modules/bounce/bounce.controller.ts b/src/app/modules/bounce/bounce.controller.ts
@@ -23,6 +23,17 @@ export const handleSns: ControllerHandler<
   never,
   ISnsNotification
 > = async (req, res) => {
+  if (req.get('x-amz-sns-message-type') === 'SubscriptionConfirmation') {
+    logger.info({
+      meta: {
+        action: 'handleSns',
+        body: req.body,
+      },
+      message: 'Handling SNS topic confirmation notification',
+    })
+    return res.sendStatus(StatusCodes.OK)
+  }
+
   const notificationResult = await BounceService.validateSnsRequest(
     req.body,
   ).andThen(() => BounceService.safeParseNotification(req.body.Message))

diff --git a/src/app/routes/api/v3/notifications/bounces/bounces.routes.ts b/src/app/routes/api/v3/notifications/bounces/bounces.routes.ts
@@ -11,6 +11,6 @@ export const BouncesRouter = Router()
  * Note that if anything errors in between, just return a 200
  * to SNS, as the error code to them doesn't really matter.
  *
- * @route POST /api/v3/notifications/bounce/email
+ * @route POST /api/v3/notifications/bounces/email
  */
 BouncesRouter.post('/email', handleSns)