Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

移除 alibaba-dingtalk-service-sdk #844

Closed
pirme opened this issue Oct 25, 2022 · 4 comments · Fixed by #996
Closed

移除 alibaba-dingtalk-service-sdk #844

pirme opened this issue Oct 25, 2022 · 4 comments · Fixed by #996
Assignees
@baymax55
Labels
good first issue Issues for first-time contributors in: hippo4j-all type: refactor Code refactoring work
Milestone
1.5.0

Comments

@pirme
Copy link
Member

pirme commented Oct 25, 2022

移除钉钉组件相关 API，通过项目 cn.hippo4j.common.toolkit.http.HttpUtil 调用发送。

Issue 工作：

  1. 调整 DingSendMessageHandler 逻辑。
  2. 删除 alibaba-dingtalk-service-sdk 相关地址。
<dependency>
    <groupId>com.aliyun</groupId>
    <artifactId>alibaba-dingtalk-service-sdk</artifactId>
    <version>${dingtalk-sdk.version}</version>
</dependency>
@pirme pirme added good first issue Issues for first-time contributors type: refactor Code refactoring work in: hippo4j-all labels Oct 25, 2022
@baymax55
Copy link
Contributor

baymax55 commented Nov 3, 2022

assign to me

@magestacks
Copy link
Member

@baymax55 Welcome

@magestacks magestacks added this to the 1.5.0 milestone Nov 3, 2022
@baymax55
Copy link
Contributor

移除钉钉组件相关 API，通过项目 cn.hippo4j.common.toolkit.http.HttpUtil 调用发送。

Issue 工作：

  1. 调整 DingSendMessageHandler 逻辑。
  2. 删除 alibaba-dingtalk-service-sdk 相关地址。
<dependency>
    <groupId>com.aliyun</groupId>
    <artifactId>alibaba-dingtalk-service-sdk</artifactId>
    <version>${dingtalk-sdk.version}</version>
</dependency>

应该去了解钉钉机器人http推送吗,或者其他的钉钉接口吗,如果有用过相关的文档的话可以提示下.没有的话我就自己去调研了

@magestacks
Copy link
Member

可以找下 钉钉开放文档，如果没有对应 http 接口，只能通过看源码了。

baymax55 added a commit to baymax55/hippo4j that referenced this issue Nov 18, 2022
@baymax55
use http instead of alibaba-dingtalk-service-sdk(opengoofy#844)
02e9a6a
@baymax55 baymax55 mentioned this issue Nov 18, 2022
Merged
magestacks pushed a commit that referenced this issue Nov 22, 2022
@baymax55
use http instead of alibaba-dingtalk-service-sdk(#844) (#996)
1910ddc 
* use http instead of alibaba-dingtalk-service-sdk

* rm alibaba-dingtalk-service-sdk dependency

* optimize DingMsg result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baymax55 baymax55

Labels
good first issue Issues for first-time contributors in: hippo4j-all type: refactor Code refactoring work
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

use http instead of alibaba-dingtalk-service-sdk(#844) baymax55/hippo4j
3 participants
@baymax55 @pirme @magestacks