do not enable transaction if TX token is an empty string #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this would avoid complexity to handle lack on secrets (in PR from forks where secret is not available
Guts
approved these changes
Feb 8, 2024
| if tx_api_token is not None: | ||
| if tx_api_token: |
There was a problem hiding this comment.
It's almost equivalent no? Are you sure that will have the expected effect?
By the way, it's not really impacting so we can approve, merge and see.
There was a problem hiding this comment.
In case you give it an empty string in the command line. But, I must say I didn't check it's actually an empty string in python.
nirvn
pushed a commit
to nirvn/qgis-plugin-ci
that referenced
this pull request
Aug 1, 2024
this would avoid complexity to handle lack on secrets (in PR from forks where secret is not available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this would avoid complexity to handle lack on secrets (in PR from forks where secret is not available