Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect subparser, missing exception guards (release 2.8.2) #262

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

why-not-try-calmer
Copy link
Contributor

Was notified that CIs are choking on the no_validation flag. Here is the fix. This went unnoticed in tests as the tests don't use the particular parser/subparser structure as the code base.

@why-not-try-calmer why-not-try-calmer changed the title Fix incorrect subparser, missing exception guards Fix incorrect subparser, missing exception guards (release 2.8.2) Dec 21, 2023
@why-not-try-calmer why-not-try-calmer force-pushed the fixing-wrong-subparser-missing-exceptions branch 2 times, most recently from a1ef32b to a1cc9dd Compare December 21, 2023 11:22
@why-not-try-calmer why-not-try-calmer force-pushed the fixing-wrong-subparser-missing-exceptions branch from a1cc9dd to c2b5b75 Compare December 21, 2023 11:28
@why-not-try-calmer why-not-try-calmer force-pushed the fixing-wrong-subparser-missing-exceptions branch from 0e66f05 to dc7b521 Compare December 21, 2023 11:40
@3nids 3nids merged commit df39548 into master Dec 21, 2023
3 checks passed
@3nids 3nids deleted the fixing-wrong-subparser-missing-exceptions branch December 21, 2023 14:23
@Guts Guts added the bug Something isn't working label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants