Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CLI and SDK for push delta files #65

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Adding CLI and SDK for push delta files #65

merged 6 commits into from
Oct 2, 2024

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Sep 21, 2024

No description provided.

@SeqLaz SeqLaz requested a review from suricactus September 21, 2024 19:19
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/cli.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
qfieldcloud_sdk/cli.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Mostly remove the try/except blocks. Almost there!

suricactus
suricactus approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

suricactus
suricactus approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@suricactus suricactus merged commit 2d6c74f into master Oct 2, 2024
8 checks passed
@suricactus suricactus deleted the adding_push_delta_method_on_cli_sdk branch October 2, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeqLaz @suricactus