Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types, don't import global Response anymore #44

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Fix types, don't import global Response anymore #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f8ea7
Fix types, don't import global `Response` anymore
suricactus Jul 28, 2023
e0655df
Single dash means single symbol
suricactus Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qfieldcloud_sdk/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def logout(ctx):

@cli.command()
@click.option(
"-off",
"-o",
"--offset",
type=int,
default=None,
Expand Down Expand Up @@ -382,7 +382,7 @@ def delete_files(ctx, project_id, paths, throw_on_error):
help="Job type. One of package, delta_apply or process_projectfile.",
)
@click.option(
"-off",
"-o",
"--offset",
type=int,
default=None,
Expand Down
5 changes: 3 additions & 2 deletions qfieldcloud_sdk/sdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import requests
import urllib3
from requests.models import Response

from qfieldcloud_sdk.interfaces import QfcException, QfcRequest, QfcRequestException
from qfieldcloud_sdk.utils import get_numeric_params, log
Expand Down Expand Up @@ -744,7 +743,9 @@ def _request(
return response

@staticmethod
def _serialize_paginated_results(response: Response) -> List[Dict[str, Any]]:
def _serialize_paginated_results(
response: requests.Response,
) -> List[Dict[str, Any]]:
"""Serialize results. Notify en passant users if results are paginated."""
total_count_header = response.headers.get("X-Total-Count")

Expand Down