Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip downloading the S3 metadata if skip_metadata=1 is passed to the API /files/ list endpoint #39

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

suricactus
Copy link
Collaborator

The metadata (the field sha256) for each file version is not needed,
since the SDK is using a md5 checksum that is provided anyways.

@suricactus suricactus added the enhancement New feature or request label Jul 12, 2023
@duke-nyuki
Copy link
Collaborator

@suricactus suricactus force-pushed the QF-2910-skip-metadata branch from 482cdd3 to acef6d4 Compare July 12, 2023 09:57
src/qfieldcloud_sdk/cli.py Outdated Show resolved Hide resolved
…e API `/files/` list endpoint

The metadata (the field `sha256`) for each file version is not needed,
since the SDK is using a md5 checksum that is provided anyways.
@suricactus suricactus force-pushed the QF-2910-skip-metadata branch from acef6d4 to 7ff3c6e Compare July 12, 2023 11:00
@suricactus
Copy link
Collaborator Author

@m-kuhn Allowed myself to force-push the comment.

@suricactus suricactus merged commit 8b519c7 into master Jul 12, 2023
@suricactus suricactus deleted the QF-2910-skip-metadata branch July 12, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants