Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pagination parameters to the projects endpoint (2/3) #36

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Add support for pagination parameters to the projects endpoint (2/3) #36

merged 2 commits into from
Jul 10, 2023

Conversation

why-not-try-calmer
Copy link
Contributor

@why-not-try-calmer why-not-try-calmer commented Jul 10, 2023 •
edited
Loading

  • added pagination options to list_project_files & list_projects
  • fixed erroneous type hints
  • fixed failing pre-commit config

@duke-nyuki
Copy link
Collaborator

Task linked: QF-2873 Add pagination to the QFC API endpoints

@why-not-try-calmer why-not-try-calmer changed the title - added pagination options to list_projects Pagination Jul 10, 2023
@why-not-try-calmer why-not-try-calmer force-pushed the QF-2873_pagination_projects_project_files branch from 518fb57 to 68e452f Compare July 10, 2023 07:48
suricactus
suricactus reviewed Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would give green light for some history rewriting. Don't squash things that are completely unrelated into one commit, e.g. the CI changes and the code.

src/qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
src/qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
src/qfieldcloud_sdk/cli.py Outdated Show resolved Hide resolved
@why-not-try-calmer why-not-try-calmer force-pushed the QF-2873_pagination_projects_project_files branch from 3eafa92 to 1c157ac Compare July 10, 2023 12:55
@why-not-try-calmer why-not-try-calmer force-pushed the QF-2873_pagination_projects_project_files branch from 1c157ac to 4a26c3a Compare July 10, 2023 12:58
@why-not-try-calmer why-not-try-calmer changed the base branch from master to fixing-updating-ci July 10, 2023 12:59
@why-not-try-calmer why-not-try-calmer changed the title Pagination Pagination (2/3) Jul 10, 2023
@why-not-try-calmer why-not-try-calmer force-pushed the QF-2873_pagination_projects_project_files branch from 4a26c3a to 1e7efce Compare July 10, 2023 13:15
Base automatically changed from fixing-updating-ci to master July 10, 2023 15:24
@suricactus suricactus changed the title Pagination (2/3) Add support for pagination parameters to the projects endpoint (2/3) Jul 10, 2023
@suricactus suricactus merged commit a3625a2 into master Jul 10, 2023
@suricactus suricactus deleted the QF-2873_pagination_projects_project_files branch July 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@why-not-try-calmer @duke-nyuki @suricactus