Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account username as fallback login #114

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Account username as fallback login #114

merged 2 commits into from
Oct 29, 2024

Conversation

signedav
Copy link
Member

No description provided.

@signedav signedav marked this pull request as draft October 28, 2024 16:33
@signedav signedav marked this pull request as ready for review October 29, 2024 11:25
@signedav signedav marked this pull request as draft October 29, 2024 12:00
…name (mostly the systems account user name) like e.g. kerberos.

For that we did:
- pass the account name as fall back on every get_uri call except the one to write the layers (since there not needed)
- means in the factories as well in the post_generate_project_validations
- and in the utils we pass the account name always on get_db_connector
- then we allow empty usernames in get_configuration_from_sourceprovider and we set the mode as configuration.tool
Copy link
Collaborator

@gacarrillor gacarrillor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
(I haven't tested it, though)

@signedav signedav merged commit 647761c into main Oct 29, 2024
5 checks passed
@signedav signedav deleted the account-username branch October 29, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants