Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plotlymap): improvement file handling #982

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

slowy07
Copy link
Member

@slowy07 slowy07 commented Nov 17, 2024

adding more improvement including

  • error handling
    • handle potential exception while loading data file
  • ensure that require latitude, longitude, z exist in input data frame, if any these missing, it will be raise error

@slowy07
Copy link
Member Author

slowy07 commented Nov 17, 2024

uv install errors
image

@slowy07 slowy07 requested a review from giswqs November 17, 2024 14:52
@giswqs giswqs merged commit 84e6391 into opengeos:master Nov 17, 2024
15 checks passed
@slowy07 slowy07 deleted the plotlymap branch November 18, 2024 05:37
pierdubo pushed a commit to pierdubo/leafmap that referenced this pull request Dec 12, 2024
* chore(plotlymap): improvement file handling

Signed-off-by: slowy07 <[email protected]>

* fix(revert): change `data.copy()` to `data`

Signed-off-by: slowy07 <[email protected]>

---------

Signed-off-by: slowy07 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants