Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import the common module by default #1003

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Import the common module by default #1003

merged 1 commit into from
Nov 28, 2024

Conversation

giswqs
Copy link
Member

@giswqs giswqs commented Nov 28, 2024

The removal of the common module import by default breaks many downstream packages. This PR brings back the common import.

@giswqs giswqs changed the title Improve the common module by default Import the common module by default Nov 28, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 22:19 Inactive
@mergify mergify bot merged commit e5740ec into master Nov 28, 2024
16 checks passed
Copy link

mergify bot commented Nov 28, 2024

Thanks for the contribution @giswqs 🤩

@mergify mergify bot deleted the common branch November 28, 2024 22:20
giswqs added a commit that referenced this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant