-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpp 17 / std::filesystem wip #6844
Conversation
Great work @ofTheo ! What do you think we could use to opt for different Project.xcconfig versions? |
Yeah I think maybe the default could be C++17 and then using the PG template system for macOS 10.14 which can't handle C++17 - that should be fairly easy. I don't think there are other platforms which couldn't just be C++17 going forward ( will see as we get the rest of the platforms in this PR ). |
I think most platforms should support c++17 without problem. I would even remove boost at some point once we deprecate whatever version of macos is the latest that doesn't support c++17. boost was always a temporary thing to get rid of poco until there was support for std::fs |
@arturoc great! sounds good. |
Thanks @danoli3! |
seems to be working now! |
Hey Theo (and others) thank you so much for working on this! I'm always in awe of how the development team keeps oF current and relevant on so many different platforms. Looking forward to using the TBB library on macOS with c++17. I'd help if my skills were better; I'd be completely lost trying to do this. So many many thanks and excited to see these kinds of projects in process! |
@chilina you're welcome - thanks for the note! |
So looks like Android will have to wait till the NDK update from @danoli3 Everything else is working just need to clean it up a bit and do a couple more tests.
|
I've tested cpp17 and std::filesystem in the night build with Visual Studio 2022. Works great! Results here. |
This PR is for addressing the last things from #6585
The code changes needed for OF are all done from previous PRs.
This PR is to simplify the process of enabling cpp 17 ( or newer ) for a project.
One common theme is that we need to both set the cpp version to c++17 but also define OF_USING_STD_FS=1.I am wondering maybe could we just detect c++17 in ofConstants.h and auto enable OF_USING_STD_FS if not defined
Edit: going with auto detect as it makes everything cleaner.
Status: