Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ofx network #6675

Merged
merged 4 commits into from
Jan 31, 2021
Merged

Fix ofx network #6675

merged 4 commits into from
Jan 31, 2021

Conversation

oxillo
Copy link
Contributor

@oxillo oxillo commented Jan 29, 2021

As proposed in #6457

  • Deprecate ofxNetworkCheckError()
  • Add int ofxNetworkGetLastError() to return the last error
  • Add void ofxNetworkLogError(int err, const char* file, int line) to log an error that happened on line line in file file
  • Add ofxNetworkLogLastError() that is a shortcut for ofxNetworkLogError(ofxNetworkGetLastError(), FILE, LINE)

Separates getting the error and logging it as it is done
in ofxNetworkCheckErrno()
Update  documentation
@ofTheo
Copy link
Member

ofTheo commented Jan 29, 2021

@oxillo thanks for this!!
To be totally honest, I am not sure I 100% understand the fix but the logic and approach seems sounds.

I'll give it a day to let @arturoc and maybe @bakercp to chime in.

But if there is no other feedback we can merge it tomorrow. It does pass the tests and I was seeing similar issues on macOS with errors in the TCP tests before which I don't see now.

Thanks again!

@ofTheo ofTheo merged commit 0f4a403 into openframeworks:patch-release Jan 31, 2021
@oxillo oxillo deleted the fix_ofxNetwork branch January 31, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants