Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF 0.11.1 Release Checklist #6483

Closed
48 tasks done
ofTheo opened this issue Dec 1, 2019 · 8 comments
Closed
48 tasks done

OF 0.11.1 Release Checklist #6483

ofTheo opened this issue Dec 1, 2019 · 8 comments
Milestone

Comments

@ofTheo
Copy link
Member

ofTheo commented Dec 1, 2019

I found this format quite helpful to organize tracking issues for releases.
Just wanted to put this here so we can start collecting any issues/PR for the next patch release.

Please add links to issues based on testing the nightly packages on different platforms.

0.11.1 SPECIFIC:

Project Generator:

  • notarize project generator.

All Platforms:

VS2017:

MSYS2:

macOS:

Linux/ARM

iOS

emscripten

CI:

  • CI seems broken again for armv7l - maybe relating to junest?

Apothecary:

Examples:

GENERAL:

  • update the change log.
  • update the Thanks.md with scripts/dev/thanks.sh
  • update version defines in ofConstants.h.
  • change the version on ofSite and make packages.
  • update apothecary and projectGenerator submodules
  • update stable to master
@ofTheo ofTheo added this to the 0.11.1 milestone Dec 1, 2019
@roymacdonald
Copy link
Contributor

Hi, thanks @ofTheo for putting up this list.
There are two PR I did, which need to be reviewed by someone else. to me these look good.
As these are related to ofxGui, I would like to add a few more improvements to it: which I've listed in this issue. Some of these could be included in this update, that's why I am saying it here.

Can you add this tiny improvement ? I think that @elliotwoods was asking for something similar elsewhere.

This PR is more or less ok, but needs testing and a double check by someone else. I've posted some comments in the PR.

@arturoc
Copy link
Member

arturoc commented Dec 5, 2019

0.11.1 should be a patch version, no new features, I usually create a new patch branch and set it as default while we are doing patch releases. any new features can go to master for 0.12

@arturoc
Copy link
Member

arturoc commented Dec 5, 2019

about ofEventListeners: added size() method. #6022 non of the channel apis i've used in other languages have such a method. there's usually a bounded version of the channel that blocks or fails if the channel is full and makes more sense than querying the size since the back pressure management relies on the channel and not on the user. in any case i wouldn't implement it cause we can't warranty we can keep it if we move to a diferentt implementation

@ofTheo
Copy link
Member Author

ofTheo commented Dec 5, 2019

sounds good @arturoc - I imagine we can use patch-release which already exists.
I can remove anything feature related from this issue.

@ofTheo
Copy link
Member Author

ofTheo commented Jan 20, 2021

So I think we could be pretty close to doing this 0.11.1 release.

I'll try and address as many of the small issues left in this list above this week. Anything that doesn't have a clear fix or isn't reproducible I will remove.

@eduardfrigola
Copy link
Contributor

Hi Theo, #6471 caused the issue #6602.
I think we should fix #6602 (I have a fix proposal) if we want #6471 to be in this release. But I think, as it resembles more of a "new feature", this could be removed from the patch release and leave it to 0.12. What do you think?

@roymacdonald
Copy link
Contributor

roymacdonald commented Feb 26, 2021

Hi. To me it sounds more as a missing feature rather than a new one. I would implement it now, so this issue is closed and no need to remember in the future adding it for the 0.12 release.

@ofTheo ofTheo closed this as completed Mar 3, 2021
@ofTheo
Copy link
Member Author

ofTheo commented Mar 3, 2021

Thanks everyone! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants