-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pugixml update for Emscripten => 3.1.52 #358
pugixml update for Emscripten => 3.1.52 #358
Conversation
@Jonathhhan oh cool!! Yes also can you look into if any issues with the WASM files as well. We were aware the .a / .bc formats were not going to work in the future. Many of the libs have been set to compile with the WASM format to fix a lot of these static lib and not runtime systems. Do we need to make these .wasms / .o ? |
At least freetype.wasm does not work:
It does not matter much in the case of freetype, because it is replaced by the emscripten lib since some time:
Probably it would work compiled as an .o file, but I was not able to change the script accordingly... |
@danoli3 there are also some issues with libxml2 (tried the svgExample):
Just a guess, but maybe all |
Yeah you can see our original discussion here: libopenFrameworks.o: undefined symbol: FT_Init_FreeType this looks like it hasn't linked to the freetype code at all. Cairo is possible to add, however will definitely need our locally compiled FreeType as a dependancy, will have a look later /ofxSvg.o: undefined symbol: pugi::xml_attribute::set_value(char const*) I will merge this code once finished with Actions changes on bleeding currently |
@danoli3 thanks. |
Might have to rebase your commit sorry! |
@Jonathhhan yeah just fetch from upstream, then rebase your commit ontop of bleeding tip |
Needs to be compiled as an
.o
file instead of a.bc
file since Emscripten 3.1.52. See: emscripten-core/emscripten#21128