Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request assets in a separate thread #954

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat: request assets in a separate thread #954

merged 2 commits into from
Oct 31, 2024

Conversation

dfguerrerom
Copy link
Collaborator

@dfguerrerom dfguerrerom commented Oct 29, 2024

  • do the request of the assets in a separate thread, loading the component and not waiting to the response, it will be blocked until it receives all the data

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.25397% with 20 lines in your changes missing coverage. Please review.

Project coverage is 96.00%. Comparing base (a6431bb) to head (1c9a591).

Files with missing lines Patch % Lines
sepal_ui/scripts/thread_controller.py 65.51% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   96.31%   96.00%   -0.32%     
==========================================
  Files          39       40       +1     
  Lines        4015     4075      +60     
==========================================
+ Hits         3867     3912      +45     
- Misses        148      163      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfguerrerom dfguerrerom merged commit fa02412 into main Oct 31, 2024
8 checks passed
@dfguerrerom dfguerrerom deleted the assetSelect branch October 31, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants