Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity creation: improved speed (avoid validating sibling keys when not necessary) #256

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

SteRiccio
Copy link
Member

@SteRiccio SteRiccio commented Dec 14, 2024

This fix uses the node "flags" (created/updated/deleted) used by Arena (desktop) to update the RDB.
In multiple entities with key, when a new entity is added, some key nodes should be re-validated (they could be duplicate). There are 2 cases:

  • the key is marked as autoincremental: when node is created, the default value will be unique, so there is no need to validate other key nodes;
  • the key is not marked as autoincremental: only nodes with the same value should be re-validated;

When a key attribute is updated, key nodes with the same value or key nodes with errors (they could be already marked as duplicate) should be re-validated.

Once an entity is created or a node updated, all updated nodes flags should be removed (outside of RecordUpdater function call invocation).

@SteRiccio SteRiccio requested a review from ramirobg94 December 14, 2024 14:31
@SteRiccio SteRiccio self-assigned this Dec 14, 2024
@SteRiccio SteRiccio merged commit cf90ba0 into master Dec 17, 2024
5 checks passed
@SteRiccio SteRiccio deleted the fix/entity-creation branch December 17, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant