improved record update error message (#238)

* improved record update error message * code cleanup * added Dictionary interface --------- Co-authored-by: Stefano Ricci <[email protected]>
openforis · Aug 16, 2024 · c7dcffb · c7dcffb
1 parent e4c859a
commit c7dcffb
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 4 deletions.
diff --git a/src/common/Dictionary.ts b/src/common/Dictionary.ts
@@ -0,0 +1,3 @@
+export interface Dictionary<T> {
+  [key: string]: T
+}
diff --git a/src/common/index.ts b/src/common/index.ts
@@ -1,3 +1,5 @@
+export type { Dictionary } from './Dictionary'
+
 import { Validation } from '../validation'
 
 export interface ArenaObject<T> {

diff --git a/src/error/SystemError.ts b/src/error/SystemError.ts
@@ -1,8 +1,10 @@
+import { Dictionary } from '../common'
+
 export class SystemError extends Error {
   private _key: string
-  private _params: { [key: string]: any }
+  private _params: Dictionary<any>
 
-  constructor(key: string, params?: { [key: string]: any }) {
+  constructor(key: string, params?: Dictionary<any>) {
     super(key)
 
     this.name = 'SystemError'
@@ -20,7 +22,15 @@ export class SystemError extends Error {
     return this._key
   }
 
-  get params(): { [key: string]: string } {
+  get params(): Dictionary<any> {
     return this._params
   }
+
+  toJSON() {
+    const { key, params } = this
+    const { error: nestedError } = params ?? {}
+    const paramsAdjusted: Dictionary<any> =
+      nestedError && nestedError instanceof SystemError ? { ...params, error: nestedError?.toJSON() } : params
+    return { key, params: paramsAdjusted }
+  }
 }
diff --git a/src/record/recordNodesUpdater/recordNodeDependentsDefaultValuesUpdater.ts b/src/record/recordNodesUpdater/recordNodeDependentsDefaultValuesUpdater.ts
@@ -22,12 +22,13 @@ const _throwError = (params: {
   const nodeDefName = nodeDef.props.name
   const expressionsString = JSON.stringify(expressionsToEvaluate)
 
-  throw new SystemError('record.updateSelfAndDependentsDefaultValues.', {
+  throw new SystemError('record.updateSelfAndDependentsDefaultValues', {
     surveyName: survey.props.name,
     nodeDefName,
     expressionType,
     expressionsString,
     error: error.toString(),
+    errorJson: error instanceof SystemError ? error.toJSON() : null,
   })
 }