-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various PDB fixes #87
Conversation
Note:This doesn't necessarily fix things for AMBER, there are two cases where I expect failures with leap.
From a quick test at leap those seem to be the only issues for getting this working in AMBER. |
@IAlibay will remove CONECT records for now; may re-add in 0.4.0 |
For structural ions, let's use LINKS entries to indicate their coordination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me!
I've confirmed the protein PDB files can all be read in OpenMM:
from openmm.app import PDBFile
from glob import glob
filenames = glob('data/*/01_*/crd/*.pdb')
print(filenames)
# Define the keyword arguments to feed to ForceField
from openmm import unit
from openmm import app
forcefield_kwargs = { 'constraints' : app.HBonds, 'rigidWater' : True, 'removeCMMotion' : False, 'hydrogenMass' : 4*unit.amu }
# Initialize a SystemGenerator using GAFF
from openmmforcefields.generators import SystemGenerator
system_generator = SystemGenerator(forcefields=['amber/ff14SB.xml', 'amber/phosaa14SB.xml', 'amber/tip3p_standard.xml'], small_molecule_forcefield='gaff-2.11', forcefield_kwargs=forcefield_kwargs, cache='db.json')
for filename in filenames:
print(filename)
pdbfile = app.PDBFile(filename)
openmm_topology = pdbfile.topology
# Create an OpenMM System from an OpenMM Topology object
system = system_generator.create_system(openmm_topology)
Thanks for the review @jchodera ! |
Fixes #68
TODO:
pfkfb3
connection record