Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] implement PDB fixes for #52 #58

Closed
wants to merge 7 commits into from
Closed

[WIP] implement PDB fixes for #52 #58

wants to merge 7 commits into from

Conversation

IAlibay
Copy link
Collaborator

@IAlibay IAlibay commented Jul 12, 2022

This is WIP.

Opening as there are things which need to be documented as I go along.

TODO:

  • Remove ANISOU records
  • Remove icodes
  • Switch caps to HETATM
  • Rename NMA to NME
  • Fix hydrogen naming for caps + first residue
  • Separate out non-protein non-solvent non-ion entries from protein.pdb to individual sdf files
    • bace (TLA)
    • cmet (7PE)
    • eg5 (ADP)
    • pfkfb3 (POP)
    • shp2 (PO4)
  • Make sure SSBOND entries are consistent
  • Remove altloc entries

Notes:

@jchodera
Copy link
Member

Thanks so much for tackling this, @IAlibay! Copying @bobym to monitor.

Just to check, @IAlibay : Are you having to correct all of these files manually? If so, we should have @bobym report these issues to be fixed in Maestro's export or protein prep wizard.

@IAlibay
Copy link
Collaborator Author

IAlibay commented Jul 16, 2022

@jchodera - yeah so currently most of these fixes are by-hand because I don't want to disrupt the HELIX / SHEET / TURN entries. The exception here is for Thrombin where manually fixing the icode insertions for those entries + the ATOM/HETATM entries was too much.

That being said, if we don't care about the HELIX/SHEET/TURN metadata, I would advocate for re-doing all these things in one go with MDAnalysis' parser (except from the SSBOND entry stuff which has to be manual right now), and could even add in the missing bonds for the caps. This would make things a lot more reproducible.

With regards to reporting back upstream: I remember @jbluck trying this a couple of months back - he might have some insights from his own discussions with the Schrodinger folks on the matter.

@dotsdl
Copy link
Member

dotsdl commented Oct 7, 2022

Closing as no longer relevant.

@dotsdl dotsdl closed this Oct 7, 2022
@IAlibay IAlibay mentioned this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants