Improve input validation on Enterprise fees page #9960
Conversation
|
This pull request is ready for review. |
There was a problem hiding this comment.
Thanks for this one. Small comments:
- Title of the PR should be edited: we use the title as our Release notes, so they should be clear, concise and reflect what are the changes for the users ✅
- Commit d867ffe should be deleted
- Commit 340b41b should be squashed with the previous one (it's probably better for the git history to avoid this kind of commits which doesn't bring changes)
| @@ -106,7 +106,7 @@ def check_enterprise_fee_input | |||
| :preferred_flat_percent, :preferred_amount, | |||
| :preferred_first_item, :preferred_additional_item, | |||
| :preferred_minimal_amount, :preferred_normal_amount, | |||
| :preferred_discount_amount, :preferred_per_unit | |||
| :preferred_discount_amount, :preferred_per_unit, :preferred_max_items, :preffered_currency | |||
There was a problem hiding this comment.
preffered_currency
I think there is a typo on preffered
There was a problem hiding this comment.
Thanks for the review and the comments. I'll work on it 👍
|
Hi @brolinr Hope this message finds you well. Just checking in: do you still have time to apply the comments from the review? |
|
Hi @RachL . I am well thank you. I haven't yet found the time to apply the changes. I have been busy stydying for exams but I'd really appreciate it if you can help applying the comments from the review. |
sigmundpetersen
changed the title
sigmundpetersen
changed the title
|
Hi @brolinr thank you for your feedback and don't worry: life happens :) Our team is currently quite busy, so I will close the PR to make the issue available for new contributors. Hopefully one of them will be able to pick-up your PR and apply the comments. Thank you so much for your work until here! |
Improved enterprise fee validation of input? ''?
Steps to reproduce as an admin?
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates