Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load storybook only in development #9623

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Sep 2, 2022

What? Why?

Closes #9622

The storybook gem is not available in other environments than development and the app fails to boot.

What should we test?

  • Specs pass.
  • Deployment to staging works.
  • The admin customers index page loads.

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

The gem is not available in other environments an the app fails to boot.
We load view_component in the application config and it should be
automatic anyway.
@mkllnk mkllnk self-assigned this Sep 2, 2022
@mkllnk mkllnk marked this pull request as ready for review September 2, 2022 06:22
@mkllnk mkllnk merged commit 95839f8 into openfoodfoundation:master Sep 2, 2022
@mkllnk mkllnk deleted the fix-storybook branch September 2, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment of master and v4.2.11 broken
1 participant