Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds specific tax rates to each type of cost #9602

Merged

Conversation

filipefurtad0
Copy link
Contributor

@filipefurtad0 filipefurtad0 commented Aug 29, 2022

What? Why?

Closes #9556

It adds three different tax rates to:

  • the enterprise fee (15%)
  • the shipping fee (10%)
  • the line items (20%)

It also changes the way the enterprise fee is set up:

  • let! is used instead of let
  • it explicitly references its own tax category; before it was fetching the tax category from a product

What should we test?

Consistently green build.

Release notes

Changelog Category: Technical changes

The title of the pull request will be included in the release notes.

@filipefurtad0 filipefurtad0 requested a review from mkllnk August 29, 2022 17:02
Copy link
Member

@mkllnk mkllnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is great for now and I'll merge it.

@RachL comment made me think though that we need to add another spec with two tax rates that have the same percentage (20%) as this spec was before.

In FR alcohol is taxed at 20% but so is shipping.

I think that this bug affects French invoices, displaying only the alcohol part or the shipping part in the total if both are present.

@mkllnk mkllnk merged commit b74c368 into openfoodfoundation:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky] Alternative Invoice - total tax line
2 participants